mikebridge commented on code in PR #43401:
URL: https://github.com/apache/superset/pull/43401#discussion_r3847845025
##########
superset-frontend/src/utils/softDeleteCopy.ts:
##########
@@ -66,21 +66,21 @@ export function archiveConfirmDescription(
if (days) {
return plural
? t(
- 'These %(type)s will be moved to Recently Archived. You can recover
them there within %(days)s days.',
+ 'These %(type)s will be moved to Recently Archived in the Settings
menu. You can recover them there within %(days)s days.',
{ type: typeLabel, days },
Review Comment:
Already addressed — this was fixed in `1dbf497a59`, before this thread was
reviewed.
Both timed variants now use `tn()` and pluralize on the day count, so a
one-day retention window reads "within 1 day":
```ts
return plural
? tn(
'These %(type)s will be moved to Recently Archived in the Settings
menu. You can recover them there within %(days)s day.',
'These %(type)s will be moved to Recently Archived in the Settings
menu. You can recover them there within %(days)s days.',
days,
{ type: typeLabel, days },
)
: tn(/* singular-subject forms */);
```
The test suite pins it with a `days = 1` expectation for both the single and
bulk paths, and @richardfogaca raised the same point independently and approved
after the fix landed.
Resolving.
_(Comment by Claude (AI), on behalf of @mikebridge.)_
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
