codeant-ai-for-open-source[bot] commented on code in PR #43401:
URL: https://github.com/apache/superset/pull/43401#discussion_r3833745532
##########
superset-frontend/src/utils/softDeleteCopy.ts:
##########
@@ -66,21 +66,21 @@ export function archiveConfirmDescription(
if (days) {
return plural
? t(
- 'These %(type)s will be moved to Recently Archived. You can recover
them there within %(days)s days.',
+ 'These %(type)s will be moved to Recently Archived in the Settings
menu. You can recover them there within %(days)s days.',
{ type: typeLabel, days },
Review Comment:
**Suggestion:** The retention setting accepts a valid one-day window, but
this message always uses the plural unit “days”, producing “within 1 days.” Use
singular/plural-aware translation variants so the confirmation remains
grammatically correct for a one-day retention period. [logic error]
<details>
<summary><b>Severity Level:</b> Minor 🧹</summary>
```mdx
- ⚠️ Archive confirmations display incorrect singular grammar.
- ⚠️ Affects one-day chart, dashboard, and dataset retention windows.
```
</details>
[](https://docs.codeant.ai/cli/resolve-pr-comments-skill)
<details>
<summary><b>Prompt for AI Agent 🤖 </b></summary>
```mdx
This is a comment left during a code review.
**Path:** superset-frontend/src/utils/softDeleteCopy.ts
**Line:** 69:70
**Comment:**
*Logic Error: The retention setting accepts a valid one-day window, but
this message always uses the plural unit “days”, producing “within 1 days.” Use
singular/plural-aware translation variants so the confirmation remains
grammatically correct for a one-day retention period.
Validate the correctness of the flagged issue. If correct, How can I resolve
this? If you propose a fix, implement it and please make it concise.
Once fix is implemented, also check other comments on the same PR, and ask
user if the user wants to fix the rest of the comments as well. if said yes,
then fetch all the comments validate the correctness and implement a minimal fix
```
</details>
<a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F43401&comment_hash=1e019216859881acf11e1530766ce5d2c5d81e25abed426fd52a9dbf38a2862c&reaction=like'>👍</a>
| <a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F43401&comment_hash=1e019216859881acf11e1530766ce5d2c5d81e25abed426fd52a9dbf38a2862c&reaction=dislike'>👎</a>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
