EnxDev commented on code in PR #43454:
URL: https://github.com/apache/superset/pull/43454#discussion_r3851963573
##########
superset-frontend/src/explore/components/DataTablesPane/components/ResultsPaneOnDashboard.tsx:
##########
@@ -88,7 +88,12 @@ export const ResultsPaneOnDashboard = ({
return (
<Wrapper>
- <Tabs activeKey={activeTabKey} onChange={setActiveTabKey} items={items}
/>
+ <Tabs
+ fullHeight
Review Comment:
the Wrapper's `.ant-tabs/.ant-tabs-body` height rules were redundant with
fullHeight (verified by reading Tabs.tsx); removed them.
Added a regression test, but via a Tabs call-args spy rather than
toHaveStyleRule, since I found the css prop doesn't actually compile under Jest
here; the babel config used by babel-jest lacks the importSource:
`'@emotion/react'` that webpack sets, so toHaveStyleRule couldn't see the rule
at all.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
