msyavuz commented on code in PR #43454:
URL: https://github.com/apache/superset/pull/43454#discussion_r3881426715
##########
superset-frontend/src/explore/components/DataTablesPane/components/ResultsPaneOnDashboard.tsx:
##########
@@ -88,7 +88,12 @@ export const ResultsPaneOnDashboard = ({
return (
<Wrapper>
- <Tabs activeKey={activeTabKey} onChange={setActiveTabKey} items={items}
/>
+ <Tabs
+ fullHeight
Review Comment:
The revert brought back the `Wrapper` `.ant-tabs` / `.ant-tabs-body` height
rules (L31-37), but `Tabs` already emits `height: 100%` on both selectors when
`fullHeight` is set (`Tabs.tsx:67,80-82`) — re-drop them?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
