EnxDev commented on code in PR #43454:
URL: https://github.com/apache/superset/pull/43454#discussion_r3852001911
##########
superset-frontend/src/explore/components/DataTablesPane/components/ResultsPaneOnDashboard.tsx:
##########
@@ -88,7 +88,12 @@ export const ResultsPaneOnDashboard = ({
return (
<Wrapper>
- <Tabs activeKey={activeTabKey} onChange={setActiveTabKey} items={items}
/>
+ <Tabs
+ fullHeight
+ activeKey={activeTabKey}
+ onChange={setActiveTabKey}
+ items={items}
+ />
Review Comment:
Tried this first; it's not a bad-selector issue, the css prop doesn't
compile to an emotion class at all under Jest in this repo.
I rendered `<Tabs fullHeight>` in isolation and dumped the DOM: `.ant-tabs`
only carries antd's own `cssinjs class`, no `css-xxxxx` emotion class, plus a
console warning `Invalid value for prop 'css' on <div> tag`.
`webpack.config.js` sets importSource: `'@emotion/react'` on
`@babel/preset-react`, which is what makes the css prop compile the root
`babel.config.j`s` used by `babel-jest` doesn't set that, so `css-prop` styling
is a no-op under Jest everywhere in the app, not just here (the existing
fullHeight tests in Tabs.test.tsx only assert DOM structure for the same
reason).
Fixing that `Jest/Babel` gap felt out of scope for this PR, so I added a spy
on Tabs's call args asserting `fullHeight: true` is always passed instead; it
fails just as loudly if the prop gets dropped, without depending on CSS
actually rendering.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
