EnxDev commented on code in PR #43454:
URL: https://github.com/apache/superset/pull/43454#discussion_r3852004861
##########
superset-frontend/src/explore/components/DataTablesPane/components/ResultsPaneOnDashboard.tsx:
##########
@@ -88,7 +88,12 @@ export const ResultsPaneOnDashboard = ({
return (
<Wrapper>
- <Tabs activeKey={activeTabKey} onChange={setActiveTabKey} items={items}
/>
+ <Tabs
+ fullHeight
+ activeKey={activeTabKey}
+ onChange={setActiveTabKey}
+ items={items}
Review Comment:
confirmed the stale activeTabKey issue is real (a mixed chart shrinking from
N to fewer query results can orphan the active tab, rendering blank). Extracted
DataTablesPane's existing getStaleResultsTabFallback helper into a shared
utils.ts and wired the same reconciliation into ResultsPaneOnDashboard, with a
new test covering the fallback.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
