codeant-ai-for-open-source[bot] commented on code in PR #43493:
URL: https://github.com/apache/superset/pull/43493#discussion_r3855447519


##########
docs/docs/using-superset/version-history.mdx:
##########
@@ -15,29 +15,29 @@ description of what changed — "Chart renamed to Q3 
Revenue", "Added filter on
 'Region'" — rather than a raw diff. You can search the history and filter it
 down to changes on the entity itself or on the things it depends on.
 
-## Enabling it
-
-Two switches are involved, and both matter.
+## Enabling and disabling it
 
 | Setting | Type | Effect |
 | --- | --- | --- |
 | `VERSION_HISTORY` | Feature flag | Shows the version history UI |
 | `ENABLE_VERSIONING_CAPTURE` | Config value | Records versions as entities 
are saved |
 
+Both default to on. To turn the feature off:
+
 ```python
 # superset_config.py
-FEATURE_FLAGS = {"VERSION_HISTORY": True}
-ENABLE_VERSIONING_CAPTURE = True
+FEATURE_FLAGS = {"VERSION_HISTORY": False}

Review Comment:
   ✅ **Customized review instruction saved!**
   
   **Instruction:**
   > Do not flag standalone FEATURE_FLAGS assignments in documented Superset 
configuration examples; Superset merges these overrides with its default 
feature flags. Operators with existing custom overrides should add the setting 
to their existing mapping.
   
   **Applied to:**
     - `docs/docs/using-superset/version-history.mdx`
   
   ---
   💡 *To manage or update this instruction, visit: [CodeAnt AI 
Settings](https://app.codeant.ai/org/settings/learnings)*



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to