bito-code-review[bot] commented on PR #43493:
URL: https://github.com/apache/superset/pull/43493#issuecomment-5413915220
<!-- Bito Reply -->
The flagged issue is correct. Assigning a new dictionary to `FEATURE_FLAGS`
overwrites any existing flags, which can lead to unintended side effects if
other flags were previously configured. To resolve this, you should update the
`FEATURE_FLAGS` dictionary by merging the new value with the existing
configuration instead of replacing it entirely.
Here is the corrected approach for
`docs/docs/using-superset/version-history.mdx`:
```python
# superset_config.py
FEATURE_FLAGS.update({"VERSION_HISTORY": False})
ENABLE_VERSIONING_CAPTURE = False
```
This ensures that other existing feature flags are preserved while updating
the `VERSION_HISTORY` setting.
**docs/docs/using-superset/version-history.mdx**
```
# superset_config.py
FEATURE_FLAGS.update({"VERSION_HISTORY": False})
ENABLE_VERSIONING_CAPTURE = False
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
