codeant-ai-for-open-source[bot] commented on code in PR #43493:
URL: https://github.com/apache/superset/pull/43493#discussion_r3855354364
##########
docs/docs/using-superset/version-history.mdx:
##########
@@ -15,29 +15,29 @@ description of what changed — "Chart renamed to Q3
Revenue", "Added filter on
'Region'" — rather than a raw diff. You can search the history and filter it
down to changes on the entity itself or on the things it depends on.
-## Enabling it
-
-Two switches are involved, and both matter.
+## Enabling and disabling it
| Setting | Type | Effect |
| --- | --- | --- |
| `VERSION_HISTORY` | Feature flag | Shows the version history UI |
| `ENABLE_VERSIONING_CAPTURE` | Config value | Records versions as entities
are saved |
+Both default to on. To turn the feature off:
+
```python
# superset_config.py
-FEATURE_FLAGS = {"VERSION_HISTORY": True}
-ENABLE_VERSIONING_CAPTURE = True
+FEATURE_FLAGS = {"VERSION_HISTORY": False}
Review Comment:
**Suggestion:** Assigning a new dictionary here replaces the operator's
entire existing `FEATURE_FLAGS` mapping, so copying this example can silently
disable unrelated customized feature flags. Show how to add or update
`VERSION_HISTORY` while preserving the existing mapping. [logic error]
<details>
<summary><b>Severity Level:</b> Major ⚠️</summary>
```mdx
- ⚠️ Existing custom feature flags can be silently discarded.
- ❌ Configured optional features may change behavior after restart.
- ⚠️ Operators must manually reconstruct omitted flag overrides.
```
</details>
[](https://docs.codeant.ai/cli/resolve-pr-comments-skill)
[](https://app.codeant.ai/fix-in-ide?tool=cursor&prompt_id=757f1670c35c43da9ecd45dd21379832&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
[](https://app.codeant.ai/fix-in-ide?tool=vscode-claude&prompt_id=757f1670c35c43da9ecd45dd21379832&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
<details>
<summary><b>Prompt for AI Agent 🤖 </b></summary>
```mdx
This is a comment left during a code review.
**Path:** docs/docs/using-superset/version-history.mdx
**Line:** 29:29
**Comment:**
*Logic Error: Assigning a new dictionary here replaces the operator's
entire existing `FEATURE_FLAGS` mapping, so copying this example can silently
disable unrelated customized feature flags. Show how to add or update
`VERSION_HISTORY` while preserving the existing mapping.
Validate the correctness of the flagged issue. If correct, How can I resolve
this? If you propose a fix, implement it and please make it concise.
Once fix is implemented, also check other comments on the same PR, and ask
user if the user wants to fix the rest of the comments as well. if said yes,
then fetch all the comments validate the correctness and implement a minimal fix
```
</details>
<a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F43493&comment_hash=4340b4b209d2d04a11892fda1f39b3bf359eefacdbd77a56e41967a70195dfae&reaction=like'>👍</a>
| <a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F43493&comment_hash=4340b4b209d2d04a11892fda1f39b3bf359eefacdbd77a56e41967a70195dfae&reaction=dislike'>👎</a>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
