rusackas commented on code in PR #43917:
URL: https://github.com/apache/superset/pull/43917#discussion_r3939706940
##########
superset-frontend/plugins/plugin-chart-pivot-table/src/react-pivottable/Styles.ts:
##########
@@ -120,6 +134,10 @@ export const Styles = styled.div<{ isDashboardEditMode:
boolean }>`
table.pvtTable tbody tr th.pvtRowLabel {
vertical-align: baseline;
+ position: ${isDashboardEditMode ? 'inherit' : 'sticky'};
+ left: 0;
+ z-index: 1;
+ background-color: ${theme.colorBgBase};
}
Review Comment:
Accurate for multi-level row headers, but it's the scoping call from the PR
description: fixed `left: 0` only works cleanly for a single row attribute.
Multi-level would need a per-column offset computed from actual rendered widths
in `TableRenderers.tsx`, which felt like more than this fix should carry.
Tracking that as a fast-follow per the discussion on #43352.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
