rusackas commented on PR #43917:
URL: https://github.com/apache/superset/pull/43917#issuecomment-5549945841
Pushed a fix for Bito's test-assertion catch: `getComputedStyle().position`
resolves `inherit` to the parent's computed value in a real browser rather than
returning it verbatim, so the dashboard-edit-mode test was only passing because
jsdom returns the literal string. Now asserting `not.toBe('sticky')` instead,
which is the actual intent.
On the nth-child/fixed-pixel-offset suggestion for multi-level row headers:
that won't work since column widths vary by content, a hardcoded `100px` would
only be right by coincidence. Same answer as the CodeAnt thread below, this is
the single-row-attribute scoping call from the PR description, multi-level
needs real per-column offsets computed from rendered widths, which I'm treating
as a fast-follow.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
