sadpandajoe commented on code in PR #43917:
URL: https://github.com/apache/superset/pull/43917#discussion_r3941607641
##########
superset-frontend/plugins/plugin-chart-pivot-table/src/react-pivottable/Styles.ts:
##########
@@ -120,6 +134,10 @@ export const Styles = styled.div<{ isDashboardEditMode:
boolean }>`
table.pvtTable tbody tr th.pvtRowLabel {
vertical-align: baseline;
+ position: ${isDashboardEditMode ? 'inherit' : 'sticky'};
+ left: 0;
+ z-index: 1;
+ background-color: ${theme.colorBgBase};
}
Review Comment:
This selector is more specific than both `table.pvtTable tr th.active` and
`.hoverable:hover`, so its background wins even when a row label is active or
hovered. That hides the existing cross-filter/hover indication on row headers.
Should those state styles take precedence over the frozen-cell background?
##########
superset-frontend/plugins/plugin-chart-pivot-table/src/react-pivottable/Styles.ts:
##########
@@ -39,6 +39,20 @@ export const Styles = styled.div<{ isDashboardEditMode:
boolean }>`
top: 0;
}
+ /* Corner cell(s) sitting above the frozen row-label column: the
+ * placeholder cell spanning the column-attribute rows, and the
+ * row-attribute name cell(s) in the final header row. Needs a
+ * higher z-index than .pvtRowLabel so it stays on top when both
+ * stick at the same scroll position. */
+ table.pvtTable thead tr:first-of-type th[aria-hidden='true'],
+ table.pvtTable thead tr:last-of-type th.pvtAxisLabel {
+ position: ${isDashboardEditMode ? 'inherit' : 'sticky'};
+ top: 0;
+ left: 0;
+ z-index: 2;
Review Comment:
The sticky `thead` is a separate stacking context, so this cell's `z-index:
2` cannot outrank the row labels' `z-index: 1`. After scrolling both axes, a
row label can paint over the frozen corner header. Should the header/totals
layer be given an explicit higher stacking order?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
