sadpandajoe commented on code in PR #43917:
URL: https://github.com/apache/superset/pull/43917#discussion_r3963895146
##########
superset-frontend/plugins/plugin-chart-pivot-table/src/react-pivottable/Styles.ts:
##########
@@ -33,10 +33,30 @@ export const Styles = styled.div<{ isDashboardEditMode:
boolean }>`
line-height: 1.4;
}
+ /* The sticky thead and totals row each form their own stacking
+ * context, so a z-index on a cell inside them can't outrank the
+ * frozen row labels (z-index 1) in the body. The bands themselves
+ * carry the z-index that keeps them painting over row labels
+ * scrolling underneath. */
table thead {
background-color: ${theme.colorBgBase};
position: ${isDashboardEditMode ? 'inherit' : 'sticky'};
top: 0;
+ z-index: 2;
+ }
+
+ /* Corner cell(s) sitting above the frozen row-label column: the
+ * placeholder cell spanning the column-attribute rows, and the
+ * row-attribute name cell(s) in the row-header row (which only
+ * renders when there are row dimensions). The z-index keeps them
+ * over the column labels scrolling underneath within the thead. */
+ table.pvtTable thead tr:first-of-type th[aria-hidden='true'],
Review Comment:
With both row and column dimensions, `spaceCell` is only `rowAttrs.length`
columns wide while the merged row-header/body label spans one more. This
selector freezes only that narrower spacer, so the column-attribute header
still scrolls through the remaining corner strip. Should the full leading block
in the column-header rows match the merged span?
##########
superset-frontend/plugins/plugin-chart-pivot-table/src/react-pivottable/Styles.ts:
##########
@@ -55,6 +75,7 @@ export const Styles = styled.div<{ isDashboardEditMode:
boolean }>`
table.pvtTable tbody tr.pvtRowTotals {
Review Comment:
With column totals enabled, the totals row's leading `pvtRowTotalLabel`
still scrolls horizontally while body row labels are frozen. At a horizontal
offset it leaves the left edge and the totals values, now above labels at
z-index 2, paint over that column. Should the leading totals cell also stick at
`left: 0`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
