mikebridge commented on PR #44028: URL: https://github.com/apache/superset/pull/44028#issuecomment-5706423258
Good catch on the [misleading duplicate-title error](https://github.com/apache/superset/pull/44028#issuecomment-5669335466). Published in `058a0ef5e0348a1305d109d81e6c999bd2bb0583` (including the preserved `26d2bfadae` fix): malformed chart layouts have a distinct error type and MCP guidance; generic invalid parameters retain the title guidance. The regression exercises the DAO's actual validation error. Copy remapping also normalizes legacy string/float IDs so live slots point to their clones. Following the explicit archived-member decision, **copy dashboard AND charts** replaces an archived member's slot with “This archived chart was not copied.”, retaining layout but neither cloning nor linking the archived original. The real restore-command regression verifies that restoring the original cannot reattach it to the copy, including after another save. Source layout/membership, ordinary save/restore reattachment and copy-without-charts remain unchanged. This updates the archived-copy statement in the [earlier hard-deleted-slot follow-up](https://github.com/apache/superset/pull/44028#issuecomment-5684729269); the hard-deleted-slot repair remains intact. Observed control: the new test failed for both cached/fresh source collections before the production fix; it passes afterward. Final local verification: 48 affected unit tests and 7 targeted SQLite API/DAO integration tests passed, complete-branch changed-file pre-commit passed, and full-branch Python/type plus independent Claude exact-snapshot review completed. These are scoped local results, not a claim that new-head CI is green. Known limitations remain explicit in the PR body: a live chart referenced by layout but not source membership still makes copy-with-charts fail closed; MCP's source-layout wording is imprecise for that membership mismatch. No new policy for those nonmember slots was chosen. The separate direct-IN query-size follow-up remains non-GA-blocking and is not claimed fixed. No threads were automatically resolved. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
