mikebridge commented on PR #44028: URL: https://github.com/apache/superset/pull/44028#issuecomment-5736524560
Thanks @richardfogaca — addressed your September 18 18:11Z review in https://github.com/apache/superset/commit/d5f03a9b9c78c0596852d8d2b955441977eaae01. 1. The REST copy endpoint catches DashboardInvalidError and returns normalized 422 details. HTTP regressions cover malformed layout IDs with and without chart duplication and assert rollback plus source layout/membership preservation. 2. Kept the disclosed fail-closed policy for live nonmember slots, without broadening the archived-member placeholder decision. The error names the offending slot and says its chart is outside the dashboard membership, rather than synthesizing a null chart ID and reporting malformed input. A regression reproduces removing membership while retaining the layout. Also changed isdigit() to isdecimal(): superscript ² is rejected as malformed, while decimal Unicode digits remain accepted. The new cases were observed failing before the fixes. On the approved final tree, 12 focused integration tests and 46 unit tests passed; full branch pre-commit passed, including main MyPy and Pylint. Independent final-tree review approved with zero findings. Existing live-chart clone and archived-placeholder/restore behavior remains covered. No threads resolved. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
