mikebridge commented on PR #44028: URL: https://github.com/apache/superset/pull/44028#issuecomment-5708884355
Follow-up to https://github.com/apache/superset/pull/44028#issuecomment-5707904969: on head 058a0ef5e0348a1305d109d81e6c999bd2bb0583, MCP calls CopyDashboardCommand.run(), whose @transaction wrapper rolls back before on_error re-raises DashboardLayoutInvalidError. I exercised the real decorated command with the DAO raising that actual exception: rollback called once, commit not called, transaction flag cleared before the exception reached the caller. The MCP entry path does not add an outer transaction. Thus the omitted second rollback in this handler does not establish pending clone writes on this path; no production change made. This check mocks the session/DAO failure, not a claim of a new database integration run. Existing copy/restore regression evidence remains in the preceding follow-up. Current-head reported checks have no failures/pending entries; reviewer confirmation is still needed, and no threads were auto-resolved. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
