codeant-ai-for-open-source[bot] commented on code in PR #44148:
URL: https://github.com/apache/superset/pull/44148#discussion_r4044689390
##########
superset/mcp_service/chart/tool/get_chart_data.py:
##########
@@ -177,8 +180,20 @@ def _build_candidates(
numeric = [c for c in columns if c.data_type == "numeric"]
categorical = [c for c in columns if c.data_type in ("string", "boolean")]
+ numeric_names = {c.name.lower() for c in numeric}
+ categorical_names = {
+ c.name.lower()
+ for c in categorical
+ if c.data_type == "string" and 1 < c.unique_count <= 250
+ }
if temporal and numeric:
return _candidates_temporal_numeric(numeric, row_count)
+ if {"latitude", "longitude"} <= numeric_names:
+ return ["geographic points", "table"]
Review Comment:
**Suggestion:** Datasets containing latitude, longitude, and any temporal
numeric column return temporal recommendations first, so geographic points are
never suggested for common time-spatial data.
**Assessment:** ๐ `Major` ยท ๐ `Occurrence: Sometimes` ยท ๐ท๏ธ `Incorrect
condition logic`
[](https://docs.codeant.ai/cli/resolve-pr-comments-skill)
[](https://app.codeant.ai/fix-in-ide?tool=cursor&prompt_id=e4b7c2a8842a41b696a88211034a9f5a&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
[](https://app.codeant.ai/fix-in-ide?tool=vscode-claude&prompt_id=e4b7c2a8842a41b696a88211034a9f5a&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
<details>
<summary><b>Prompt for AI Agent ๐ค </b></summary>
```mdx
This is a comment left during a code review.
**Path:** superset/mcp_service/chart/tool/get_chart_data.py
**Line:** 191:192
**Comment:**
*Incorrect Condition Logic: Datasets containing latitude, longitude,
and any temporal numeric column return temporal recommendations first, so
geographic points are never suggested for common time-spatial data.
Validate the correctness of the flagged issue. If correct, How can I resolve
this? If you propose a fix, implement it and please make it concise.
Once fix is implemented, also check other comments on the same PR, and ask
user if the user wants to fix the rest of the comments as well. if said yes,
then fetch all the comments validate the correctness and implement a minimal fix
```
</details>
<a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F44148&comment_hash=de97493341d57b2516bdb674d2c22d625c9090c377ec1b517d8245564d9839b1&reaction=like'>๐</a>
| <a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F44148&comment_hash=de97493341d57b2516bdb674d2c22d625c9090c377ec1b517d8245564d9839b1&reaction=dislike'>๐</a>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
