p2er commented on code in PR #44148:
URL: https://github.com/apache/superset/pull/44148#discussion_r4045698266
##########
superset/mcp_service/chart/chart_helpers.py:
##########
@@ -485,6 +485,20 @@ def resolve_metrics(form_data: dict[str, Any], viz_type:
str) -> list[Any]:
if viz_type == "bubble":
return [m for field in ("x", "y", "size") if (m :=
form_data.get(field))]
+ if viz_type in {"country_map", "world_map"}:
+ from superset.mcp_service.chart.query_result import metric_result_label
+
+ result = []
+ labels = set()
+ for field in (
+ ("metric", "secondary_metric") if viz_type == "world_map" else
("metric",)
+ ):
+ if metric := form_data.get(field):
Review Comment:
Resolved in ab5b04d0a: `probe_review` now invokes `set_keychain_free_helper
"$REVIEW_CHECKOUT" >/dev/null 2>&1 || true` immediately before probing
credentials, repairing unmigrated clones idempotently rather than refusing them
and requiring a manual `--install-deps`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
