aminghadersohi commented on code in PR #44148:
URL: https://github.com/apache/superset/pull/44148#discussion_r4082244035
##########
superset/translations/uk/LC_MESSAGES/messages.po:
##########
@@ -7997,6 +8009,10 @@ msgstr "Стовпець GeoJSON"
msgid "GeoJson Settings"
msgstr "Параметри GeoJSON"
+#, python-format
Review Comment:
Checked against the generating source and regenerated all catalogs with
./scripts/translations/babel_update.sh (Babel 2.17.0, as pinned in
requirements/development.txt). The generated POT and Ukrainian PO both retain
python-format for this msgid.
You are correct that this exact translatable string is JS-only:
transformData.ts calls t("Geographic metric %s must be a finite number",
label), while query_result.py raises an unlocalized ValueError using an
f-string. The Python code is not a second extraction source for this msgid.
However, Babel messages.catalog.Message.__init__ automatically adds
python-format when Message.python_format recognizes percent-format syntax,
independent of the extractor/source language. Directly extracting the JS call
and constructing Message(msgid) reproduces {"python-format"}. Thus the flag
describes Babel’s recognized formatting syntax here, not evidence of a Python
source. This simple %s placeholder is compatible with that format check.
Hand-changing it to javascript-format would diverge from the generated output
and be reverted on the next update. No source/generator change is warranted for
this string; keeping the regenerated Babel output.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
