bito-code-review[bot] commented on code in PR #44148: URL: https://github.com/apache/superset/pull/44148#discussion_r4082245518
########## superset/translations/uk/LC_MESSAGES/messages.po: ########## @@ -7997,6 +8009,10 @@ msgstr "Стовпець GeoJSON" msgid "GeoJson Settings" msgstr "Параметри GeoJSON" +#, python-format Review Comment: <!-- Bito Reply --> The reviewer's suggestion to change the format flag to `javascript-format` is based on the assumption that the string originates solely from a JavaScript source. However, as you noted, Babel's extraction process automatically applies `python-format` when it detects percent-format syntax, regardless of the source language. Since the current output is correctly generated by Babel and matches the expected format for this string, the existing `python-format` flag is appropriate and should be maintained to avoid divergence during future updates. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
