rusackas commented on PR #43695:
URL: https://github.com/apache/superset/pull/43695#issuecomment-5883714981
Rebased this on `master` now that #43566 landed, since the two overlapped on
aurora/clickhouse/elasticsearch/ibmi/odps. A few things worth flagging from
that process:
Aurora's `AuroraMySQLEngineSpec`/`AuroraPostgresEngineSpec` connection
strings used `{user}` in the placeholder but `parameters` documents
`"username"`, so I switched those to `{username}` to match. Also combined
`AuroraMySQLDataAPI`/`AuroraPostgresDataAPI`'s `default_port` (which fixes the
`KeyError` in `build_sqlalchemy_uri` codeant flagged) with this PR's
`parameters`/`docs_url`/`known_incompatibilities` additions, since both were
real and neither side had both.
`kusto.py`'s `KustoKqlEngineSpec` auto-merged with two sequential `metadata
= {...}` assignments (no conflict flagged, since the hunks were adjacent rather
than overlapping) — the second one silently won at runtime and dropped
`known_incompatibilities`/`docs_url`/`sqlalchemy_docs_url`. Caught it because
`test_kql_metadata` failed after the merge; removed the stale duplicate.
One thing that's still actually open: `DatabricksNativeEngineSpec`'s
metadata still has `databricks-dbapi[sqlalchemy]` and the
`databricks+connector://` scheme that @sadpandajoe flagged as
SQLAlchemy-1.x-only. I don't see the fix mentioned in the thread actually in
the branch, so that one's still worth a look.
Full test suite (1791 tests) and pre-commit are green on the rebased branch.
Happy to help with the Databricks fix or anything else that comes up.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
