bito-code-review[bot] commented on code in PR #43695: URL: https://github.com/apache/superset/pull/43695#discussion_r4161258296
########## tests/unit_tests/db_engine_specs/test_lint_metadata.py: ########## @@ -0,0 +1,65 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, +# either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. + +import tempfile +from pathlib import Path +from textwrap import dedent + +from superset.db_engine_specs import lint_metadata +from superset.db_engine_specs.lint_metadata import get_all_engine_specs_ast + + +def test_get_all_engine_specs_ast_annotated_attributes() -> None: + """ + Ensure engine specs with type-annotated engine, engine_name, and metadata + are correctly discovered and parsed by get_all_engine_specs_ast. + """ + specs_dir = Path(lint_metadata.__file__).parent + code = dedent( + """ + from typing import Any + from superset.db_engine_specs.base import BaseEngineSpec + + class TypedBaseEngineSpec(BaseEngineSpec): + engine: str = "typed_engine" + engine_name: str = "Typed Engine" + metadata: dict[str, Any] = { + "description": "A typed engine spec", + } + """ + ) + + with tempfile.NamedTemporaryFile( + mode="w", + dir=specs_dir, Review Comment: <div> <div id="suggestion"> <div id="issue"><b>Test pollutes package source dir</b></div> <div id="fix"> Writing the temp spec into the real `superset/db_engine_specs/` package dir (`specs_dir`, line 31) couples the test to a writable source tree: it errors on read-only/wheel installs, and any failure between file creation (line 46) and the `finally` (line 64) leaks `_tmp_typed_*.py` into the package. Redirect the scan root used by `get_all_engine_specs_ast` (`os.path.dirname(__file__)`) to a pytest tmp dir instead. </div> </div> <small><i>Code Review Run #a77c3d</i></small> </div> --- Should Bito avoid suggestions like this for future reviews? (<a href=https://alpha.bito.ai/home/ai-agents/review-rules>Manage Rules</a>) - [ ] Yes, avoid them -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
