codeant-ai-for-open-source[bot] commented on code in PR #43695:
URL: https://github.com/apache/superset/pull/43695#discussion_r4129663376
##########
superset/db_engine_specs/aurora.py:
##########
@@ -55,6 +79,34 @@ class AuroraPostgresDataAPI(PostgresEngineSpec):
"region_name={region_name}"
)
+ metadata = {
+ "description": (
+ "Amazon Aurora PostgreSQL via the Data API for serverless
connectivity."
+ ),
+ "logo": "aws-aurora.jpg",
+ "homepage_url": "https://aws.amazon.com/rds/aurora/";,
+ "categories": [
+ DatabaseCategory.CLOUD_AWS,
+ DatabaseCategory.HOSTED_OPEN_SOURCE,
+ ],
+ "pypi_packages": ["sqlalchemy-aurora-data-api"],
+ "connection_string": (
+
"postgresql+auroradataapi://{aws_access_id}:{aws_secret_access_key}@/"
+ "{database_name}?aurora_cluster_arn={aurora_cluster_arn}&"
+ "secret_arn={secret_arn}®ion_name={region_name}"
+ ),
+ "parameters": {
+ "aws_access_id": "AWS Access Key ID",
+ "aws_secret_access_key": "AWS Secret Access Key",
+ "database_name": "Database name",
+ "aurora_cluster_arn": "Aurora cluster ARN",
+ "secret_arn": "Secrets Manager ARN for credentials",
+ "region_name": "AWS region (e.g., us-east-1)",
+ },
+ "docs_url":
"https://docs.aws.amazon.com/AmazonRDS/latest/AuroraUserGuide/";,
+ "known_incompatibilities": AURORA_DATA_API_KNOWN_INCOMPATIBILITIES,
+ }
Review Comment:
✅ **CodeAnt verified this suggestion was addressed in subsequent commits and
marked this thread resolved** as of `9cb06b6`.
Added `"default_port": 5432` to the Aurora PostgreSQL Data API metadata,
preventing the inherited URI builder from raising a `KeyError` when no port is
supplied.
<sub>If that's not right, unresolve this thread and CodeAnt will leave it
open.</sub>
<!-- codeant-auto-resolve-reply -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
