FrancescoCastaldi commented on PR #43695:
URL: https://github.com/apache/superset/pull/43695#issuecomment-5938978929

   Added a regression test in 
`tests/unit_tests/db_engine_specs/test_lint_metadata.py` as requested by 
@sadpandajoe: it verifies that `get_all_engine_specs_ast()` discovers 
`TypedBaseEngineSpec(BaseEngineSpec)` with type-annotated `engine`, 
`engine_name`, and `metadata`, preserving the annotated attributes so any 
future regressions in the AST scanning logic fail the test.
   
   Unit tests and `lint_metadata.py` checks pass cleanly.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to