gabotorresruiz commented on code in PR #45147:
URL: https://github.com/apache/superset/pull/45147#discussion_r4262390230
##########
superset-frontend/src/explore/components/controls/FilterControl/AdhocFilterEditPopoverSimpleTabContent/index.tsx:
##########
@@ -551,15 +553,21 @@ const AdhocFilterEditPopoverSimpleTabContent: FC<Props> =
props => {
// does not exist. Each note is only shown when it applies.
helperText: suggestionsDisabled
? t('Suggestions are unavailable for this view. Enter a value manually.')
- : suggestionsUnavailable
- ? t('Suggestions could not be loaded. You can still type a value.')
- : optionsTruncated
- ? t(
- 'Only the first %s values are listed. Type to search all of
them, ' +
- 'or enter a value that is not listed.',
- loadedOptionCount,
- )
- : undefined,
+ : suggestionsError ||
+ (suggestionsUnavailable
+ ? t('Suggestions could not be loaded. You can still type a value.')
+ : optionsTruncated
+ ? props.datasource?.type === 'semantic_view'
+ ? t(
+ 'Only the first %s values are listed. Enter a value manually
if it is not listed.',
Review Comment:
Just a small NIT: this drops the search promise for every semantic
dimension, including the `string` ones where the `LIKE` still reaches the
provider, so a text column's picker now reads as if typing only filters the
loaded page.
Is that deliberate because `type_generic` cannot tell the frontend whether
the backend will narrow (`get_column_type` reports `STRING` for `binary` and
`list` too, and those are not narrowed), or would splitting on the generic type
here be worth it? Happy either way, I might be missing something.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
