mikebridge commented on code in PR #45147:
URL: https://github.com/apache/superset/pull/45147#discussion_r4263969840
##########
superset-frontend/src/explore/components/controls/FilterControl/AdhocFilterEditPopoverSimpleTabContent/index.tsx:
##########
@@ -551,15 +553,21 @@ const AdhocFilterEditPopoverSimpleTabContent: FC<Props> =
props => {
// does not exist. Each note is only shown when it applies.
helperText: suggestionsDisabled
? t('Suggestions are unavailable for this view. Enter a value manually.')
- : suggestionsUnavailable
- ? t('Suggestions could not be loaded. You can still type a value.')
- : optionsTruncated
- ? t(
- 'Only the first %s values are listed. Type to search all of
them, ' +
- 'or enter a value that is not listed.',
- loadedOptionCount,
- )
- : undefined,
+ : suggestionsError ||
+ (suggestionsUnavailable
+ ? t('Suggestions could not be loaded. You can still type a value.')
+ : optionsTruncated
+ ? props.datasource?.type === 'semantic_view'
+ ? t(
+ 'Only the first %s values are listed. Enter a value manually
if it is not listed.',
Review Comment:
Codex verification at
[e4e75cff63](https://github.com/apache/superset/commit/e4e75cff63e3d706314be0485c58bae8ba71a7a7):
yes, this conservative wording is deliberate. The values path sends LIKE for
Arrow string, large_string and string_view (including dictionaries with those
value types). Binary and list dimensions do not receive LIKE. The metadata sent
to this picker reports type_generic=STRING for all of those, including
dictionary<int64>, which also does not receive LIKE, so splitting on the
generic type would promise server-side search for dimensions where the backend
only returns the bounded page.
Text dimensions still send q and narrow at the provider; the hint does not
change that behavior. I have left the code unchanged. The follow-up is to
expose an explicit per-column search capability derived from the same backend
predicate, then use it to restore the text-specific hint with
text/binary/list/dictionary tests. Raw column.type is an Arrow display string,
so I would avoid making the frontend duplicate that parser and type policy.
Existing type/narrowing and picker-hint checks passed; no new commit for this
reply.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
