etr2460 commented on a change in pull request #9685:
URL:
https://github.com/apache/incubator-superset/pull/9685#discussion_r417516105
##########
File path:
superset-frontend/src/explore/components/controls/AdhocFilterControl.jsx
##########
@@ -125,9 +128,10 @@ export default class AdhocFilterControl extends
React.Component {
);
}
}
- },
- // no error handler, in case of error do not show partition option
- );
+ })
+ .catch(error => {
+ console.log('fetch extra_table_metadata:', error.statusText);
Review comment:
can you add an eslint disable comment here to prevent the warning?
and maybe this should be a `console.error`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
