graceguo-supercat opened a new pull request #9685: URL: https://github.com/apache/incubator-superset/pull/9685
### CATEGORY Choose one - [x] Bug Fix - [x] Enhancement (new features, refinement) - [ ] Refactor - [ ] Add tests - [ ] Build / Development Environment - [ ] Documentation ### SUMMARY In #9637 I added an API call to `/superset/extra_table_metadata` to check datasource table's metadata, if it has partition then show extra adhoc filter operator. But virtual table (when is_sqllab_view is True) doesn't have real table exists, so above metadata check will return server side error. This PR is to add is_sqllab_view check before fetching table metadata. ### TEST PLAN Manual test ### ADDITIONAL INFORMATION <!--- Check any relevant boxes with "x" --> <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue --> - [x] Has associated issue: #9637 - [ ] Changes UI - [ ] Requires DB Migration. - [ ] Confirm DB Migration upgrade and downgrade tested. - [ ] Introduces new feature or API - [ ] Removes existing feature or API ### REVIEWERS ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
