graceguo-supercat commented on a change in pull request #9685:
URL:
https://github.com/apache/incubator-superset/pull/9685#discussion_r417647315
##########
File path: superset/connectors/sqla/models.py
##########
@@ -581,6 +581,7 @@ def data(self) -> Dict:
d["main_dttm_col"] = self.main_dttm_col
d["fetch_values_predicate"] = self.fetch_values_predicate
d["template_params"] = self.template_params
+ d["is_sqllab_view"] = self.is_sqllab_view
Review comment:
It adds extra attribute in the datasource object. I am not sure how
cache key use datasource. Is this a relevant cache key code?
https://github.com/apache/incubator-superset/blob/a6cedaaa879348aca49a520793bb20e63d152a1f/superset/common/query_object.py#L199
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
