john-bodley commented on a change in pull request #9685:
URL:
https://github.com/apache/incubator-superset/pull/9685#discussion_r417607393
##########
File path: superset/connectors/sqla/models.py
##########
@@ -581,6 +581,7 @@ def data(self) -> Dict:
d["main_dttm_col"] = self.main_dttm_col
d["fetch_values_predicate"] = self.fetch_values_predicate
d["template_params"] = self.template_params
+ d["is_sqllab_view"] = self.is_sqllab_view
Review comment:
@graceguo-supercat does this impact the cache key in anyway? If so we
should probably add a note in `UPDATING.md` to inform others.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
