aglinxinyuan opened a new pull request, #7674: URL: https://github.com/apache/texera/pull/7674
### What changes were proposed in this PR? Collapses the `ReplayLogger` abstract base into its only subclass, `ReplayLoggerImpl`. Once #7452 removes `EmptyReplayLogger`, the base has a single subclass and is never named as a type anywhere: | `ReplayLogger` | Subclasses | Declared-type sites | | --- | ---: | --- | | on `main` | 2 | 1 — `EmptyReplayLoggerSpec.scala:125`, itself deleted by #7452 | | after #7452 | 1 | 0 | ``` ReplayLogManager.scala:109 private val replayLogger = new ReplayLoggerImpl() -> infers the concrete class ReplayLoggerImpl.scala:31 class ReplayLoggerImpl extends ReplayLogger -> the only subclass ReplayLogger.scala:28 abstract class ReplayLogger -> nothing else refers to it ``` So the base declares three abstract methods that exactly one class implements and that no call site dispatches through. Dropping it removes `extends ReplayLogger`, one `override` keyword that no longer overrides anything, and `ReplayLogger.scala` itself. The three method bodies are untouched: **−42 / +2 lines**, no behaviour change. `ReplayLoggerImpl` keeps its name. `ReplayLogManagerImpl` sits beside a genuine `ReplayLogManager` trait in the same package, so the `...Impl` suffix stays consistent there. > Stacked on #7452, which needs to merge first — without it the base still has two subclasses. Until then the diff here carries both commits; the collapse is the second one, `ReplayLogger.scala` + 2 lines. ### Any related issues, documentation, discussions? Closes #7673 ### How was this PR tested? Existing tests only — this is a structural change with no behaviour change, and `LogreplayPrimitivesSpec` already covers `ReplayLoggerImpl` by constructing it directly (`new ReplayLoggerImpl()`), so it pins all three methods across the refactor without modification. Locally, from the repo root with Java 17: - `sbt "WorkflowExecutionService/Test/compile"` — success. - `sbt "WorkflowExecutionService/testOnly *LogreplayPrimitivesSpec *EmptyReplayLogManagerImplSpec *ReplayLogGeneratorSpec"` — all green. - `sbt scalafmtCheckAll "scalafixAll --check"` — clean. Verification, re-runnable by a reviewer: ``` git grep -n ReplayLogger -- '*.scala' | grep -v ReplayLoggerImpl # empty ``` ### Was this PR authored or co-authored using generative AI tooling? Generated-by: Claude Code (Claude Opus 5) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
