Yicong-Huang commented on code in PR #7674:
URL: https://github.com/apache/texera/pull/7674#discussion_r3793686537
##########
amber/src/main/scala/org/apache/texera/amber/engine/architecture/logreplay/ReplayLoggerImpl.scala:
##########
@@ -28,7 +28,7 @@ import
org.apache.texera.amber.engine.common.ambermessage.WorkflowFIFOMessage
import scala.collection.mutable
-class ReplayLoggerImpl extends ReplayLogger {
+class ReplayLoggerImpl {
Review Comment:
Consider renaming this concrete class to `ReplayLogger` now that the
abstraction is gone. Keeping the `Impl` suffix implies a corresponding
interface, unlike the other interface-less classes in this package.
##########
amber/src/main/scala/org/apache/texera/amber/engine/architecture/logreplay/ReplayLoggerImpl.scala:
##########
@@ -46,7 +46,7 @@ class ReplayLoggerImpl extends ReplayLogger {
* @param channel The channel ID associated with the processing step.
Review Comment:
The Scaladoc name should match the actual `channelId` parameter.
```suggestion
* @param channelId The channel ID associated with the processing step.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
