aglinxinyuan commented on PR #7674: URL: https://github.com/apache/texera/pull/7674#issuecomment-5312280142
Thanks @Yicong-Huang — all three addressed, force-pushed as d844b3b. | Item | Status | | --- | --- | | Rename the concrete type to `ReplayLogger` | Done — `ReplayLoggerImpl` is gone, `git grep -rn ReplayLoggerImpl` is empty | | Scaladoc `@param channel` → `@param channelId` | Done, with the `@param` block re-aligned | | Stale #7452 note + rebase | Rebased onto `main`; git dropped the already-merged commit, so the branch is a single commit now, and the note is out of the description | The description is rewritten around the new naming rather than the old "keeps its name" argument, since your point stands: with the base deleted there is no abstraction for `...Impl` to distinguish against. Re-verified locally from the repo root on Java 17: - `sbt "WorkflowExecutionService/Test/compile"` — success - `sbt "WorkflowExecutionService/testOnly *LogreplayPrimitivesSpec *EmptyReplayLogManagerImplSpec *ReplayLogGeneratorSpec"` — 33 tests, all green - `sbt scalafmtCheckAll "scalafixAll --check"` — clean -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
