aglinxinyuan commented on code in PR #7674:
URL: https://github.com/apache/texera/pull/7674#discussion_r3794036686
##########
amber/src/main/scala/org/apache/texera/amber/engine/architecture/logreplay/ReplayLoggerImpl.scala:
##########
@@ -28,7 +28,7 @@ import
org.apache.texera.amber.engine.common.ambermessage.WorkflowFIFOMessage
import scala.collection.mutable
-class ReplayLoggerImpl extends ReplayLogger {
+class ReplayLoggerImpl {
Review Comment:
Done in d844b3b — it is now just `ReplayLogger`, in `ReplayLogger.scala`,
the file the base vacated. You are right that the suffix was advertising an
interface this PR deletes, and the other suffix-free classes in the package
(`AsyncReplayLogWriter`, `ReplayOrderEnforcer`) set the precedent.
`ReplayLogManagerImpl` is untouched — the `ReplayLogManager` trait beside it is
real, so its suffix still means something.
The rename reaches one production call site (`ReplayLogManager.scala:109`)
plus the constructions and test names in `LogreplayPrimitivesSpec`. `git grep
-rn ReplayLoggerImpl` is now empty.
##########
amber/src/main/scala/org/apache/texera/amber/engine/architecture/logreplay/ReplayLoggerImpl.scala:
##########
@@ -46,7 +46,7 @@ class ReplayLoggerImpl extends ReplayLogger {
* @param channel The channel ID associated with the processing step.
Review Comment:
Applied in d844b3b. I also re-aligned the two neighbouring descriptions —
the block was column-aligned on the 7-character `channel`, so `channelId`
widened it by two.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
