Lukas Reichlin wrote: > On 06.05.2010, at 22:24, Alois Schlögl wrote: > >> After looking further into the problem of converting octave code >> into a matlab compatible syntax, I concluded that in some cases it >> is easiest way to make the source code compatible. In some cases, >> there is just no way to make an automated conversion. E.g there is >> no good way to convert while (k++ == N) in a automated way. >> Converting the source code is a simpler and more straight forward >> way. >> >> The attached patch is doing this. The difficult cases like ++, --, >> +=, -=, /=, &=, *=, |=, and do-until are replaced. Most of the >> octave specific syntax (like endfor, endwhile, ## comment, etc.) >> stays in place. >> >> Are there are any objections on committing this patch ? >> >> >> Alois > > I'm the main author and maintainer of control and I have some strong > objections against that. The reason is that I don't get the point of > your suggested changes: As Matlab has its own control package, IMO > nobody will use it on Matlab anyway. Furthermore, the package uses a > lot of oct-files which are Octave-specific as well. Don't get me > wrong, contributions/improvements are always welcome and there is a > lot of room for them :-) But those automatic changes just mess things > up, sorry. > > Regards, Lukas
Lukas, thanks for your comments. I'm not sure I understand your comment on "those automated changes just mess things up". The point of the patch is that in some cases its better to use a manual change in the source code, rather than applying an automated script. You are right Mathworks sells a control toolbox. But it does not mean that everyone with a Matlab license has also a license for the control toolbox. Just recently, I did a course at the university in a computer lab with 20 people. Licenses for Matlab were available, and at the first glimpse it seems that also all necessary toolboxes were available (we needed about 5 functions from signal and statistics toolbox). However, when we tried to use functions from these toolboxes, these licenses were locked to some other department and we could not use them. Such a situation can also happen to users of the control toolbox. Concering Oct-files: you are right, oct-files can not be converted. For this reason, I'm prefering the use of the mex-interface. The mex-interface is also open, and available to Octave. If you want to keep your the control toolbox to octave only, that's ok. But I can imagine that also matlab users might be interested in your work. Regards, Alois ------------------------------------------------------------------------------ _______________________________________________ Octave-dev mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/octave-dev
