> On Лют. 1, 2017, 2:18 після полудня, Albert Astals Cid wrote: > > This works fine for me without your patch, so it's either that you use too > > old versions and the new ones are fixed or that i use too old versions and > > the new one has regressed. > > > > Which KF5/Qt5 versions are you using.
I do have this problem for quite some time already (for a year, perhaps). The versions are 5.8.0 for Qt and Git master for KF5. Could you check whether the QIODevice from KArchiveFile::createDevice() is seekable in your case, please? - Eugene ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129909/#review102335 ----------------------------------------------------------- On Лют. 1, 2017, 1:56 після полудня, Eugene Shalygin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/129909/ > ----------------------------------------------------------- > > (Updated Лют. 1, 2017, 1:56 після полудня) > > > Review request for Okular and Albert Astals Cid. > > > Repository: okular > > > Description > ------- > > Okular refuses to load .cbr files because a `QIODevice` object returned by > `KArchiveFile::createDevice()` is not seekable and because of that > `QImageLoader` can't detect image format. Proposed solution: if that device > is not seekable or `QIODevice::size()` returns 0, copy its content into a > temporary file and load image from it. > > > Diffs > ----- > > generators/comicbook/document.cpp 34c4cb5a > > Diff: https://git.reviewboard.kde.org/r/129909/diff/ > > > Testing > ------- > > Well, it loads .cbr files now :) > > > Thanks, > > Eugene Shalygin > >
