> On Лют. 1, 2017, 2:18 після полудня, Albert Astals Cid wrote: > > This works fine for me without your patch, so it's either that you use too > > old versions and the new ones are fixed or that i use too old versions and > > the new one has regressed. > > > > Which KF5/Qt5 versions are you using. > > Eugene Shalygin wrote: > I do have this problem for quite some time already (for a year, perhaps). > The versions are 5.8.0 for Qt and Git master for KF5. > Could you check whether the QIODevice from KArchiveFile::createDevice() > is seekable in your case, please? > > Eugene Shalygin wrote: > I was wrong abou that. What seems to be important is that when > `QIODevice::size()` returns 0, `QImageLoader` refuses to detect format. The > patch has been corrected. > > Eugene Shalygin wrote: > Actually, the thing is even simpler: QIODevice::seek() does not work with > the `dev` object in my case.
result of KArchiveFile::createDevice() for ZIP archives behaves strangely in other cases on my system. I will investigate. - Eugene ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129909/#review102335 ----------------------------------------------------------- On Лют. 1, 2017, 4:44 після полудня, Eugene Shalygin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/129909/ > ----------------------------------------------------------- > > (Updated Лют. 1, 2017, 4:44 після полудня) > > > Review request for Okular and Albert Astals Cid. > > > Repository: okular > > > Description > ------- > > Okular refuses to load .cbr files because a `QIODevice` object returned by > `KArchiveFile::createDevice()` reports its size to be 0 and because of that > `QImageReader` refuses to read. Proposed solution: if that device's > `QIODevice::size()` returns 0, copy its content into a temporary file and > load image from the file. > > > Diffs > ----- > > generators/comicbook/document.cpp 34c4cb5a > > Diff: https://git.reviewboard.kde.org/r/129909/diff/ > > > Testing > ------- > > Well, it loads .cbr files now :) > > > Thanks, > > Eugene Shalygin > >