----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129909/ -----------------------------------------------------------
(Updated Лют. 1, 2017, 4:02 після полудня) Review request for Okular and Albert Astals Cid. Changes ------- The correct trigger which makes QImageLoader fail, is QIODevice::size() == 0 Repository: okular Description ------- Okular refuses to load .cbr files because a `QIODevice` object returned by `KArchiveFile::createDevice()` is not seekable and because of that `QImageLoader` can't detect image format. Proposed solution: if that device is not seekable or `QIODevice::size()` returns 0, copy its content into a temporary file and load image from it. Diffs (updated) ----- generators/comicbook/document.cpp 34c4cb5a Diff: https://git.reviewboard.kde.org/r/129909/diff/ Testing ------- Well, it loads .cbr files now :) Thanks, Eugene Shalygin