----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129909/#review102349 -----------------------------------------------------------
It's a bug in KArchive or a bug in Qt. https://mail.kde.org/pipermail/kde-frameworks-devel/2017-February/042506.html - Albert Astals Cid On feb. 1, 2017, 3:44 p.m., Eugene Shalygin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/129909/ > ----------------------------------------------------------- > > (Updated feb. 1, 2017, 3:44 p.m.) > > > Review request for Okular and Albert Astals Cid. > > > Repository: okular > > > Description > ------- > > Okular refuses to load .cbr files because a `QIODevice` object returned by > `KArchiveFile::createDevice()` reports its size to be 0 and because of that > `QImageReader` refuses to read. Proposed solution: if that device's > `QIODevice::size()` returns 0, copy its content into a temporary file and > load image from the file. > > > Diffs > ----- > > generators/comicbook/document.cpp 34c4cb5a > > Diff: https://git.reviewboard.kde.org/r/129909/diff/ > > > Testing > ------- > > Well, it loads .cbr files now :) > > > Thanks, > > Eugene Shalygin > >