On Fri, 24 Jul 2020 21:29:06 GMT, Kevin Rushforth <k...@openjdk.org> wrote:
>> Nir Lisker has updated the pull request with a new target base due to a >> merge or a rebase. The pull request now >> contains 11 commits: >> - Merge branch 'master' into 8217472_Add_attenuation_for_PointLight >> - Attenuation and range changed internally to floats from doubles >> - Fixed shader compilation errors for 2 and 3 lights in es2 >> - Addressing review comments >> - Fixed whitespaces >> - Correction for indexes >> - Docs and year update >> - Merge remote-tracking branch >> 'nlisker/8217472_Add_attenuation_for_PointLight' into >> 8217472_Add_attenuation_for_PointLight >> - GL pipeline >> - Separate range from attenuation >> - ... and 1 more: >> https://git.openjdk.java.net/jfx/compare/4ec163df...2e1223ed > > modules/javafx.graphics/src/main/java/javafx/scene/PointLight.java line 51: > >> 50: * results in the light's color being subtracted from the material >> instead of added to it, thus creating a >> 51: * "shadow caster". >> 52: * <p> > > Can you think of any problems that might arise by supporting negative > coefficients? If not, then this seems fine. No, I've tested the functionality and it seemed to be working well. ------------- PR: https://git.openjdk.java.net/jfx/pull/43
