On Fri, 24 Jul 2020 21:41:04 GMT, Kevin Rushforth <k...@openjdk.org> wrote:
> 1. The API docs look good. If you change the public API to `@since 16` then > you can also update the CSR and move it to > the "Submitted" state. I moved it to the PROPOSED state. > 2. I think it would be good to cleanup the performance test and make it part > of this PR, maybe in `tests/performance` > (which currently only has the not-very-useful `VMPerformance` subdir) or > `tests/manual`. I added it under `tests/performance`. > 3. We need some functional tests, ideally automated ones in `tests/system` What should this test do? Which example should I follow? By the way, The `tests` project is broken in Eclipse because several source folders, like `tests\system\src\testapp6`, define their own `module-info.java`, and it's illegal in Eclipse to have several of these in a project. To have the tests there compile, the Eclipse files will need to be updated. ------------- PR: https://git.openjdk.java.net/jfx/pull/43
