On Sat, 24 Oct 2020 18:26:29 GMT, Kevin Rushforth <[email protected]> wrote:
>>> @rwestberg I was pleasantly surprised to see the Skara bot add this: >>> >>> > Linux x64 >>> > Windows x64 >>> > macOS x64 >>> > >>> > >>> > >>> > >>> > Build / test >>> > heavy_check_mark (1/1 passed) >>> > heavy_check_mark (1/1 passed) >>> > heavy_check_mark (1/1 passed) >>> >>> I was going to ask you what I needed to do so that you could generate this. >>> I guess the short answer is that what I've already done is sufficient. >>> Thanks! >> >> I noticed this in the openjdk/mobile repository as well, and that looks >> great. In that repository, there seems to be a different configuration, as >> there is a line for "build" and a line for "test/tier 1" ( e.g. >> https://github.com/openjdk/mobile/pull/10 ) >> >> I wonder how configurable this is? > > The jdk workflow is split into a build job and multiple test jobs (since it > takes so long they need the parallelism when running the tests). It's more > complicated that way, since you have to feed the results of the build job > into all of the test jobs, and there is duplication of some of the > configuration steps. I don't know that it would buy us much, so I wasn't > planning to split the jobs -- at leat not initially. > > The build and test are done in separate steps within the job so it's easy to > see which one failed. Maybe Robin can comment further as to whether we could > do something a bit more clever. > I noticed this in the openjdk/mobile repository as well, and that looks > great. In that repository, there seems to be a different configuration, as > there is a line for "build" and a line for "test/tier 1" ( e.g. > [openjdk/mobile#10](https://github.com/openjdk/mobile/pull/10) ) > > I wonder how configurable this is? The output is not very configurable at all. :) You can see https://github.com/openjdk/skara/blob/bd4cc7e9a6ff7b04c6dc650a969638d5c1471031/bots/pr/src/main/java/org/openjdk/skara/bots/pr/TestResults.java#L42 for details. But it should support additional tiers at least if any were added in the future. ------------- PR: https://git.openjdk.java.net/jfx/pull/338
