On Fri, 9 Feb 2024 15:53:20 GMT, Andy Goryachev <ango...@openjdk.org> wrote:
>> Kevin Rushforth has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Address review feedback > > tests/system/src/test/java/test/robot/javafx/scene/TransparentLCDTest.java > line 67: > >> 65: * >> 66: * @test >> 67: * @bug 8311492 > > for my education: what is the meaning of these tags? how are they used? These are jtreg tags. They aren't used now, since we don't use jtreg to run our tests, but might in the future. > tests/system/src/test/java/test/robot/javafx/scene/TransparentLCDTest.java > line 81: > >> 79: // color, or in the middle of the text fill area, where we expect to >> find >> 80: // the unadjusted text color. >> 81: private static final double TOLERANCE = 2.0 / 255.0; > > if the intent is to allow for 2 levels of difference, perhaps it should be > (2.0 / 255) + 0.00001 or something Maybe. Or maybe even `2.5 / 255.0`. I like the latter idea better, so will do that. ------------- PR Review Comment: https://git.openjdk.org/jfx/pull/1361#discussion_r1484508446 PR Review Comment: https://git.openjdk.org/jfx/pull/1361#discussion_r1484512704
