On Fri, 9 Feb 2024 15:58:12 GMT, Kevin Rushforth <k...@openjdk.org> wrote:

>> tests/system/src/test/java/test/robot/javafx/scene/TransparentLCDTest.java 
>> line 81:
>> 
>>> 79:     // color, or in the middle of the text fill area, where we expect 
>>> to find
>>> 80:     // the unadjusted text color.
>>> 81:     private static final double TOLERANCE = 2.0 / 255.0;
>> 
>> if the intent is to allow for 2 levels of difference, perhaps it should be 
>> (2.0 / 255) + 0.00001 or something
>
> Maybe. Or maybe even `2.5 / 255.0`. I like the latter idea better, so will do 
> that.

yes, much better, thank you.

-------------

PR Review Comment: https://git.openjdk.org/jfx/pull/1361#discussion_r1484514261

Reply via email to