On Fri, 25 Jul 2025 21:02:26 GMT, Andy Goryachev <ango...@openjdk.org> wrote:
>> I commented on all the places where Eclipse gives a warning in this PR. Do >> you want me to upload the compiler settings? I think we discussed at some >> point the need to upload the formatter and other setting to the repo. > > We might, at some point, but my question is about .classpath files probably. > I don't see MSLBackend.java as being on the source path, which makes me think > you have a different setup, and I'd like to know the difference. > > Speaking of errors, I currently have the errors configured to show 0 > warnings. In this particular case, > > `unlikely argument type for collection methods using 'Object'` and > `Unlikely argument type for method equals()` both set to WARNING, though > `Perform strict analysis against the expected type` is not checked. > > If I enable the latter, I get 229 warnings all over the place. > > My concern is that what you found is a real issue, yet (at least my config) > does not show it. Oh, I thought you were saying that you didn't see that warning because of the compiler configuration, not the project configuration. I manually added the source folders that are relevant to this PR and that are not in the default configuration. I'm not sure if there's merit to change the classpath file in the repo. `unlikely argument type for collection methods using 'Object'` without `Perform strict analysis against the expected type` is enough to give this warning. ------------- PR Review Comment: https://git.openjdk.org/jfx/pull/1824#discussion_r2232015150
