Hi,

Please feel free to announce the paper here with the results of the
research once it's ready.

On Thu, Feb 26, 2015 at 09:34:09AM +0000, Radjino Bholanath wrote:
> 1. Do all developers (contributors and core developers) have to
> submit a code review for every change? I’m asking because many
> projects only review changes made by contributors.

Every (except for the two special "new release" and "restore normal
development") patch merged to master has to go through public code
review. That means that at least one of the developers who has that
right should mark the patch +2 on Gerrit. Sometimes people +2 their
own patches (if it's trivial or if nobody else is willing do to
review). Nobody is obliged to review code.

> 2. Which code review tools are used?

Gerrit.

> 3. Are static analyzers used? If they are used:
>   a. Is passing the checks of the static analyzers necessary for a change to 
> be accepted?
>   b. Which static analyzers are used?

For a change to be accepted, both GCC and clang should not emit any
warnings with these options activated:

-Wall -Wstrict-prototypes -Wformat-security -Wshadow -Wextra
-Wno-unused-parameter -Wbad-function-cast -Wcast-align
--Wredundant-decls

Clang Static Analyzer is also used but its warnings do not
automatically lead to a patch getting rejected (in fact people rarely
pay attention to it).

-- 
Be free, use free (http://www.gnu.org/philosophy/free-sw.html) software!
mailto:fercer...@gmail.com

------------------------------------------------------------------------------
Dive into the World of Parallel Programming The Go Parallel Website, sponsored
by Intel and developed in partnership with Slashdot Media, is your hub for all
things parallel software development, from weekly thought leadership blogs to
news, videos, case studies, tutorials and more. Take a look and join the 
conversation now. http://goparallel.sourceforge.net/
_______________________________________________
OpenOCD-devel mailing list
OpenOCD-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/openocd-devel

Reply via email to