Paul Fertser wrote: > > 1. Do all developers (contributors and core developers) have to > > submit a code review for every change? I’m asking because many > > projects only review changes made by contributors. > > Every (except for the two special "new release" and "restore normal > development") patch merged to master has to go through public code > review. That means that at least one of the developers who has that > right should mark the patch +2 on Gerrit. Sometimes people +2 their > own patches (if it's trivial or if nobody else is willing do to > review).
Please know that the +2 "code review" does not mean much, possibly because there is no formal agreement on what it requires, which makes the review score utterly subjective. Subjective review in combination with strong desire for instant gratification after a change has been contributed results in only mediocre code quality, even though review is ongoing. And that seems perfectly acceptable to a majority of people. Kind regards //Peter ------------------------------------------------------------------------------ Dive into the World of Parallel Programming The Go Parallel Website, sponsored by Intel and developed in partnership with Slashdot Media, is your hub for all things parallel software development, from weekly thought leadership blogs to news, videos, case studies, tutorials and more. Take a look and join the conversation now. http://goparallel.sourceforge.net/ _______________________________________________ OpenOCD-devel mailing list OpenOCD-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openocd-devel
