Why did you remove winconfig.h?
On Tue, Mar 2, 2010 at 11:29 PM, Andreas Jellinghaus <a...@dungeon.inka.de>
wrote:
> we stopped installing opensc header files.
> so I thought maybe we no longer need the src/include/
> directory with the symlinks (or copies on windows).
>
> but, if we remove the src/include directory, we need
> a different mechanism to find these files. for example
> not via ${top_builddir}/src/include with opensc/file.h,
> but via ${top_srcdir}/src with libopensc/file.h.
>
> if we change that, we could as well change the #include
> <...> to #include "..." - as far as I know that doesn't
> change anything, pure optic, but usualy files part of
> the source are referenced with "...", opposed to system
> include files with <...>.
>
> I did these changes already, patch attached. not sure
> if such a big change is worth the small cleanup,
> so please let me know what you think.
> (note: doesn't work on windows right now - need to restore
> winconfig.h to win32.)
>
> other issues I noticed that we could change:
> * not all files have this: #include "config.h"
> * some use <config.h> which seems bogus to me.
> * some but not all load internal.h. maybe we no
> longer need that, as all include files are internal now?
> * I prefer to have a strict order of the include files:
> first system include files, then other libraries, then
> imported code (scconf, common etc.), then our own include
> headers. currently its a wild mix/order.
> * automake/conf/libtool add "-I." to the gcc command line.
> some files are include without directory name in some places
> (if .c and .h files are in the same directory), while using
> "dir/file.h" in other places. maybe unify that to avoid
> including the wrong file by accident.
>
> what do you think?
>
> Regards, Andreas
>
> _______________________________________________
> opensc-devel mailing list
> opensc-devel@lists.opensc-project.org
> http://www.opensc-project.org/mailman/listinfo/opensc-devel
>
_______________________________________________
opensc-devel mailing list
opensc-devel@lists.opensc-project.org
http://www.opensc-project.org/mailman/listinfo/opensc-devel
