On Mar 3, 2010, at 08:31 , Alon Bar-Lev wrote:
> Why did you remove winconfig.h?
Same question here.
> On Tue, Mar 2, 2010 at 11:29 PM, Andreas Jellinghaus <a...@dungeon.inka.de>
> wrote:
>> we stopped installing opensc header files.
Currently header files are still installed. They're not supposed to be used by
external apps and should not be packaged by installers.
>> so I thought maybe we no longer need the src/include/
>> directory with the symlinks (or copies on windows).
Tokend still requires access to libopensc headers, having it in a standard
place (/Library/OpenSC/include) would ease the building of it, as it would not
require any changes in xcode buildfiles before it can be built. Not sure if/how
it could be automated and changed to pick up headers from a custom location.
>> but, if we remove the src/include directory, we need
>> a different mechanism to find these files. for example
>> not via ${top_builddir}/src/include with opensc/file.h,
>> but via ${top_srcdir}/src with libopensc/file.h.
>>
>> if we change that, we could as well change the #include
>> <...> to #include "..." - as far as I know that doesn't
>> change anything, pure optic, but usualy files part of
>> the source are referenced with "...", opposed to system
>> include files with <...>.
>>
>> I did these changes already, patch attached. not sure
>> if such a big change is worth the small cleanup,
>> so please let me know what you think.
>> (note: doesn't work on windows right now - need to restore
>> winconfig.h to win32.)
I find the symlinking approach odd, changing it so that make and friends don't
change the structure of the package too much would be nice.
>> other issues I noticed that we could change:
>> * not all files have this: #include "config.h"
>> * some use <config.h> which seems bogus to me.
>> * some but not all load internal.h. maybe we no
>> longer need that, as all include files are internal now?
Good point.
--
Martin Paljak
http://martin.paljak.pri.ee
+3725156495
_______________________________________________
opensc-devel mailing list
opensc-devel@lists.opensc-project.org
http://www.opensc-project.org/mailman/listinfo/opensc-devel
