2012/12/8 Anthony Foiani <anthony.foi...@gmail.com>:
> Greetings --
>
> I have two small patches which you might want to consider integrating.
>
> (And given that I can't get git to do what I want, you probably want
> to just cherry-pick these, as I suspect I've completely destroyed my
> repo history...)

You should rebase your patches above OpenSC/OpenSC master.

> https://github.com/tkil/OpenSC/commit/0c4a2e0c4063f31bc41c34e45869b9a9e7ca41d7
> This uses "dir local" settings to configure Emacs indentation correctly.

I don't think that an Emacs configuration file should be added to the
OpenSC source code.
You should keep this change in your own branch.

> https://github.com/tkil/OpenSC/commit/599bd1e6c906af63eb379c866076f98a91654cb2
> I spotted an inconsistency in how the option argument pointers were
> initialized; this fixes it (to make it more consistent).

Not a bug but the code would be nicer.
Can you create a branch from OpenSC/OpenSC master with only this patch
and ask for a Pull Request?

Bye

-- 
 Dr. Ludovic Rousseau
_______________________________________________
opensc-devel mailing list
opensc-devel@lists.opensc-project.org
http://www.opensc-project.org/mailman/listinfo/opensc-devel

Reply via email to